Skip to content

[range.adaptor.object][range.adaptor.object] Index special kinds of function objects and their related operator|#8089

Merged
tkoeppe merged 4 commits into
cplusplus:mainfrom
frederick-vs-ja:index-pipeline-operators
Oct 30, 2025
Merged

[range.adaptor.object][range.adaptor.object] Index special kinds of function objects and their related operator|#8089
tkoeppe merged 4 commits into
cplusplus:mainfrom
frederick-vs-ja:index-pipeline-operators

Conversation

@frederick-vs-ja

@frederick-vs-ja frederick-vs-ja commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

As drive-by, also change \term to \defn in [customization.point.object] to index "customization point object".

Fixes #8052. Fixes #6967.

Comment thread source/lib-intro.tex Outdated

\pnum
A \term{customization point object} is a function object\iref{function.objects}
A \defn{customization point object} is a function object\iref{function.objects}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want \defn here and not, say, \defnadj?

@frederick-vs-ja frederick-vs-ja Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's better to say \defnadj{customization point}{object}, \defnadj{range adaptor closure}{object}, and \defnadj{range adaptor}{object}.
But for pipeable objects we're saying \defnadj{pipeable}{sender adaptor closure object} and \defnadj{pipeable}{sender adaptor object}, and there're no corresponding non-pipeable ones, which looks weird to me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I haven't looked in detail of how we're indexing all those things. It looks like you've spent some time on this; what would you recommend?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to say \defnadj{pipeable sender adaptor closure}{object}. It seems that the current indexing style of these things was decided by @jensmaurer during working on #7114. I'm not sure whether this was intended.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also paging @AlisdairM and @Eelis as indexing experts.

@frederick-vs-ja frederick-vs-ja force-pushed the index-pipeline-operators branch from 2db2a04 to 7339382 Compare October 17, 2025 08:49
@jensmaurer

Copy link
Copy Markdown
Member

I think this is a nice improvement over the status quo, even if this might not be the global optimum.

@tkoeppe tkoeppe merged commit ff99161 into cplusplus:main Oct 30, 2025
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the index-pipeline-operators branch October 30, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

operator| for range adaptor closure objects is not in the index No index entry for customization point object

3 participants