[macros] Restore sentence spacing after \tcode

[morinmorin]

TeX treats a word ending with an uppercase letter as an abbreviation. This makes the space after \tcode{T}. result in regular interword spacing. To restore proper (wider) sentence spacing, this commit appends \@ to the \tcode macro.

There are dozens of intances of \tcode{...UPPERCASE}.

[jensmaurer]

Could you paste a (small) screenshot of an example showing the spacing before/after this change?

Did you run "diffpdf" in a sufficiently detailed mode to ensure nothing gets broken?

[tkoeppe]

This change seems to cause us to lose some index entries. Please see std-generalindex.ilg.

[morinmorin]

Sorry for the breakage. I'll dig into it more and I'll attach a diff screenshot after it's resolved.

[morinmorin]

OK, fixed the breakage and added a comment.

[morinmorin]

There are hundreds of spacing updates.
Many are subtle/unnoticeable (typical patterns: \tcode{…UPPERCASE}, and \tcode{…UPPERCASE}; ):

Here is a typical sentence-spacing fix involving \tcode{…UPPERCASE}. :

In a few places, multiple lines reflow slightly:

There is only one instance where a paragraph extends by one line, causing a substantial page reflow (from [linalg.general] p4 to [linalg.algs.blas3.trmm] p8). This change only shifts a page break — confirmed with pdfdiff — so I think this is fine.

How to read these images (generated by diff-pdf):
Differences are color-coded — red indicates the original and cyan indicates the revised. Any line that contains a difference is marked with a red marker in the left margin.

[morinmorin]

Oops, forgot to reply to this one.

Did you run "diffpdf" in a sufficiently detailed mode to ensure nothing gets broken?

After fixing the breakage, yes, I checked with DiffPDF (and diff-pdf) and didn't find any particular problems.

[tkoeppe]

@morinmorin: Hi! Is it possible that this change has introduced a lot of new "Token not allowed in a PDF string" warnings? Are we missing some \texorpdfstring somewhere to exclude the new constructions from use in PDF specials?

[morinmorin]

@tkoeppe Thanks, you're right that this commit does introduce those warnings.

The commit log says

The insertion of \@ happens only during normal typesetting; it is suppressed when writing the .idx file and when generating bookmarks.

But it fails to suppress the insertion of \@ when generating bookmarks. A simple fix is to add

\pdfstringdefDisableCommands{\def\@{}}

to std.tex; I confirmed this fixes the issue.

[morinmorin]

Here's PR #8432 for convenience.