Skip to content

[expected.object.monadic][expected.void.monadic] Add missing necessary typename#8178

Merged
tkoeppe merged 2 commits into
cplusplus:mainfrom
frederick-vs-ja:expected-typename
Oct 30, 2025
Merged

[expected.object.monadic][expected.void.monadic] Add missing necessary typename#8178
tkoeppe merged 2 commits into
cplusplus:mainfrom
frederick-vs-ja:expected-typename

Conversation

@frederick-vs-ja

@frederick-vs-ja frederick-vs-ja commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Although it's unambiguous to implementors and users that T::value_type and T::error_type must be types, typename is still necessary to make the condition well-formed.

Fixes #8177.

@jensmaurer jensmaurer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely, you seemed to be in favor in the other thread?

@tkoeppe

tkoeppe commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Thank you (also to the reporter)!

@tkoeppe tkoeppe merged commit 617a9f1 into cplusplus:main Oct 30, 2025
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the expected-typename branch October 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expected.object.monadic] Add typename between is_same_v<U​::​error_type, E>

3 participants