[mdspan.layout.left.cons] Fix typo in Precondition.#8210
Closed
1uc wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
CI says, that now a line is too long. In hindsight, that does seem very likely, I'll fix it. |
Here `other` is a layout mapping and layout mappings don't have this API to access the `i`th extent. They only have `extents()` to get the std::extents object.
1uc
force-pushed
the
left_from_left_padded
branch
from
7b9c957 to
743d833
Compare
Contributor
Author
|
I've add the affected section to the commit message and added the \newline. The affected page has been attached it's (11.1). |
1uc
changed the title
1uc
changed the title
jwakely
approved these changes
Sep 26, 2025
Contributor
Author
|
I didn't know where to break so I searched the rest of the document; and I found a case where it broke this way. |
tkoeppe
reviewed
Nov 1, 2025
| \item | ||
| If \tcode{extents_type::rank() > 1} is \tcode{true}, | ||
| then \tcode{other.stride(1)} equals \tcode{other.extents(0)}. | ||
| then \tcode{other.stride(1)} equals \tcode{other.extents().\newline extent(0)}. |
Contributor
There was a problem hiding this comment.
Could we hyphenate "extents" instead (with \-)?
tkoeppe
added
the
changes requested
eisenwave
added
the
P1-Important
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
I took and applied this change as 2a7f36a. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here
otheris a layout mapping and layout mappings don't have this API to access theith extent. They only haveextents()to get the std::extents object. See,draft/source/containers.tex
Line 22446 in fbd1a70
for the analogous statement in layout_right.