[flat.{map,multimap,set,multiset}] Harmonize wordings in "The effect of calling..."#8212
Open
Quuxplusone wants to merge 1 commit into
Open
[flat.{map,multimap,set,multiset}] Harmonize wordings in "The effect of calling..."#8212Quuxplusone wants to merge 1 commit into
Quuxplusone wants to merge 1 commit into
Conversation
Quuxplusone
commented
Sep 5, 2025
| that is not sorted with respect to \tcode{key_comp()}, or | ||
| that contains equal elements, | ||
| that takes a \tcode{sorted_unique_t} argument | ||
| with a container, containers, or range that is not sorted with respect to \tcode{key_comp()}, or that contains equal elements, |
Contributor
Author
There was a problem hiding this comment.
I believe a "container" is a "range," so should this (and throughout) just say "with a range or ranges that (is/are)...", "with a range or containers that (is/are)...", or any variation along those lines? I wasn't able to come up with a phrasing that wasn't icky. IMO the benefit of not-too-awful grammar is worth the cost of redundancy here.
jwakely
reviewed
Sep 5, 2025
jwakely
reviewed
Sep 5, 2025
Quuxplusone
force-pushed
the
flatmeowub
branch
from
97acd4a to
aff64b4
Compare
Quuxplusone
force-pushed
the
flatmeowub
branch
from
aff64b4 to
1b17ea2
Compare
wg21bot
added
the
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this in the review of P3567 "
flat_meowfixes" today; and this is not one of the things that it's going to fix, so might as well do it editorially first.The egregious editorial issue here is that one place says "a container, containers, or range that is not sorted with respect to
key_comp()," and another place says "a container, containers, or range that are not sorted with respect tokey_comp()." We should fix the latter. Drive-by harmonize the exact wording and the line-breaks in each similar sentence:"The effect of calling a meow"
"that has this property"
"with these arguments"
"is undefined".