[meta.type.synop] Remove redundant cast in constant_wrapper declaration#8218
Conversation
|
I've re-pushed this with a commit message that matches the NB comment format. |
|
Sorry, but you're confused about the commit message format. We want the traditional subject line unmodified (label + short text), and in the body of the commit message, we want "Fixes NB US 79-146 (C++26 CD)". See fb46e16 for an example. |
|
I was going by what it says here: https://github.com/cplusplus/draft/wiki/Commit-message-format#commits-from-committee-papers I'll fix it tomorrow |
|
Ah, we've never done it that way. I've fixed the wiki: https://github.com/cplusplus/draft/wiki/Commit-message-format#nb-comment-resolutions Sorry for the confusion. |
The use of `decltype(cw-fixed-value(X))` instead of just `decltype(X)` is a workaround for a GCC bug: https://gcc.gnu.org/PR117392 There's no need for the standard to specify it this way. Fixes NB US 79-146 (C++26 CD).
|
Should be fixed now. Do we want the "Fixes cplusplus/nbballot/..." part in the pull request description, or do we not want the related nbballot issue to be auto-closed? |
|
Auto-closing the nbballot issue is good; the "Fixes" establishes a link for later archeology. |
3 participants
The use of
decltype(cw-fixed-value(X))instead of justdecltype(X)is a workaround for a GCC bug: https://gcc.gnu.org/PR117392There's no need for the standard to specify it this way.
The
typenameis redundant too, but that's a separate topic.Fixes cplusplus/nbballot#725