Skip to content

[func.wrap.ref.class] Use ArgTypes instead of Args #8219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hewillk wants to merge 2 commits into from
Closed

[func.wrap.ref.class] Use ArgTypes instead of Args #8219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22bf754
[func.wrap.ref.class] Use ArgTypes instead of Args
hewillk Sep 10, 2025
4ca1957
Fix line length issue
hewillk Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions source/utilities.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14960,7 +14960,7 @@
template<class... T>
static constexpr bool @\exposidnc{is-invocable-using}@ = @\seebelownc@; // \expos

R (*@\exposidnc{thunk-ptr}@)(@\exposidnc{BoundEntityType}@, Args&&...) noexcept(@\placeholdernc{noex}@); // \expos
R (*@\exposidnc{thunk-ptr}@)(@\exposidnc{BoundEntityType}@, ArgTypes&&...) noexcept(@\placeholdernc{noex}@); // \expos
@\exposidnc{BoundEntityType}@ @\exposidnc{bound-entity}@; // \expos
};

Expand All @@ -14976,15 +14976,15 @@

\pnum
An object of class
\tcode{function_ref<R(Args...) \cv{} noexcept(\placeholder{noex})>}
\tcode{function_ref<R(ArgTypes...) \cv{} noexcept(\placeholder{noex})>}
stores a pointer to function \exposid{thunk-ptr} and
an object \exposid{bound-entity}.
\exposid{bound-entity} has
an unspecified trivially copyable type \exposid{BoundEntityType}, that
an unspecified trivially copyable type \linebreak{} \exposid{BoundEntityType}, that

@eisenwave eisenwave Nov 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, please don't add forced line breaks like this.

Suggested change
an unspecified trivially copyable type \linebreak{} \exposid{BoundEntityType}, that
an unspecified trivially copyable type \exposid{Bound\-Entity\-Type}, that

... would presumably work, assuming you were coping with overful hboxes due to BoundEntityType going off the side of the page.

@tkoeppe tkoeppe Nov 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me at least split off the bug fix from the discretionary tweaks then.

models \libconcept{copyable} and
is capable of storing a pointer to object value or a pointer to function value.
The type of \exposid{thunk-ptr} is
\tcode{R(*)(\exposidnc{BoundEntityType}, Args\&\&...) noexcept(\placeholder{noex})}.
\tcode{R(*)(\exposidnc{BoundEntityType}, ArgTypes\&\&...) noexcept(\placeholder{noex})}.

\pnum
Each specialization of \tcode{function_ref} is
Expand All @@ -14995,7 +14995,7 @@
Within \ref{func.wrap.ref},
\tcode{\placeholder{call-args}} is an argument pack with elements such that
\tcode{decltype((\placeholder{call-args}\linebreak{}))...} denote
\tcode{Args\&\&...} respectively.
\tcode{ArgTypes\&\&...} respectively.

@tkoeppe tkoeppe Nov 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely: this change is a bug fix, too, right? Here we're again referring to the class template synopsis.

@jwakely jwakely Nov 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, that's right

@tkoeppe tkoeppe Nov 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


\rSec4[func.wrap.ref.ctor]{Constructors and assignment operators}

Expand Down