Fix typo in submdspan_extents.#8243
Merged
Merged
Conversation
Contributor
Author
|
That makes sense. I've added a commit to address the issue. If you don't want to do a "squash and merge", let me know and I'll force push a single commit. |
The pack `Extents` must be a pack of `size_t` integers. This typo is affects both [mdspan.syn] and [mdspan.sub.extents].
1uc
force-pushed
the
1uc/typo-submdspan_extents
branch
from
0ff2283 to
7992a8a
Compare
Contributor
Author
|
I've updated the commit message to mention [view.multidim] and squashed the two commits together. |
jensmaurer
approved these changes
Sep 27, 2025
Contributor
|
@jwakely I was traveling and just got back -- is everything OK now? |
Member
|
Yes, I think this change was correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pack
Extentsmust be a pack ofsize_tintegers.