[mdspan.sub.sub] Fix typo in submdspan Effect:.#8248
Merged
Conversation
jwakely
requested changes
Sep 26, 2025
jwakely
left a comment
jwakely
left a comment
Member
There was a problem hiding this comment.
Please update the first line of the commit message to start with "[mdspan.sub.sub]" - looks good otherwise
1uc
force-pushed
the
1uc/fix-submdspan-effect
branch
from
e9f96ae to
fb15bb1
Compare
1uc
changed the title
Effect:.Effect:.
jwakely
reviewed
Sep 26, 2025
The class `mdspan` doesn't have a member `data`, it has `data_handle` (which returns a generalized pointer). This "data handle" is what's passed, together with an offset, to the accessor to "shift the pointer". The `AccessorPolify::offset_policy` is a type alias and therefore needs a preceeding `typename`. Co-authored-by: Jonathan Wakely <github@kayari.org>
1uc
force-pushed
the
1uc/fix-submdspan-effect
branch
from
78c9c6e to
2b1a7ce
Compare
Contributor
Author
|
I've added the |
jwakely
approved these changes
Sep 29, 2025
jensmaurer
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class
mdspandoesn't have a memberdata, it hasdata_handle(which returns a generalized pointer). This "data handle" is what's passed, together with an offset, to the accessor to "shift the pointer".