[filebuf.virtuals] Add missing const to pointer variables#8259
Merged
Conversation
The fourth parameter of `codecvt::out` and `codecvt::in` are `const C*&`, but _Effects_ use `C*` variables, which makes the call ill-formed. The intent seems sufficient clear and we should probably use `const C*` variables in these places.
frederick-vs-ja
force-pushed
the
filebuf-ptr-const
branch
from
786ee9c to
287d65e
Compare
frederick-vs-ja
changed the title
const to pointer variablesconst to pointer variables] Add missing const to pointer variables
frederick-vs-ja
changed the title
const to pointer variables] Add missing const to pointer variablesconst to pointer variables
Member
|
@jwakely , could you have a look, please? Looks reasonable to me, at least... |
Contributor
|
@jwakely could you confirm that this is OK editorially? |
jwakely
approved these changes
Oct 31, 2025
jwakely
left a comment
jwakely
left a comment
Member
There was a problem hiding this comment.
Yes, the intent is clear but this is needed to make the code well-formed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fourth parameter of
codecvt::outandcodecvt::inareconst C*&, but Effects useC*variables, which makes the call ill-formed.The intent seems sufficient clear and we should probably use
const C*variables in these places.Fixes #8256.