Skip to content

[meta.reflection.result] move declaration of TCls earlier#8362

Merged
tkoeppe merged 1 commit into
cplusplus:mainfrom
jwakely:meta.reflection.result-tcls
Oct 31, 2025
Merged

[meta.reflection.result] move declaration of TCls earlier#8362
tkoeppe merged 1 commit into
cplusplus:mainfrom
jwakely:meta.reflection.result-tcls

Conversation

@jwakely

@jwakely jwakely commented Oct 24, 2025

Copy link
Copy Markdown
Member

Fixes NB US 117-178 (C++26 CD).

Fixes https://github.com/cplusplus/nbballot/issues/747

But I wonder if we should name this something other than TCls seeing as that name is used for a class template in at least five examples elsewhere in reflection wording. Maybe the invented template here should have a different name to avoid any risk of confusion.

@jwakely jwakely force-pushed the meta.reflection.result-tcls branch from 1f33e64 to 104c05d Compare October 24, 2025 17:13
@eisenwave eisenwave added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 25, 2025
@eisenwave

eisenwave commented Oct 26, 2025

Copy link
Copy Markdown
Member

What is the rationale for the name TCIs anyway?

Maybe something like CTP (constant template parameter) would work? After all, it seems like CTP is really just being used to wrap a constant template parameter here. If you wanted to, you could also use std::nontype/std::constant_arg and wouldn't need to invent any class template.

Anyhow, the current change looks correct and like a clear improvement.

@jwakely

jwakely commented Oct 26, 2025

Copy link
Copy Markdown
Member Author

It's TCls with an L not TCIs with i

It's short for "template class", but any other name except T would work here.

@tkoeppe tkoeppe merged commit ffd997c into cplusplus:main Oct 31, 2025
2 checks passed
@jwakely jwakely deleted the meta.reflection.result-tcls branch October 31, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ballot-comment Response to an NB or ISO comment on a ballot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants