Skip to content

[meta] reflect_constant_array of an empty range returns const array<T,0>#8364

Merged
hanickadot merged 1 commit into
cplusplus:mainfrom
hanickadot:reflect-constant-array-const-array
Oct 24, 2025
Merged

[meta] reflect_constant_array of an empty range returns const array<T,0>#8364
hanickadot merged 1 commit into
cplusplus:mainfrom
hanickadot:reflect-constant-array-const-array

Conversation

@hanickadot

Copy link
Copy Markdown
Contributor

Marek Poláček asked in SG7 Mattermost if it should return const or not, I think for consistency it should be. If others agree this is PR fixing it.

(attempt number two for pr #8361, as I didn't notice I'm targetting not the main branch, sorry)
#8361 (comment)

@jwakely jwakely left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LWG discussed this in telecon and agreed with the change. https://eel.is/c++draft/temp.param#13.sentence-1 says the object has a const type.

@hanickadot hanickadot merged commit e256ce2 into cplusplus:main Oct 24, 2025
4 checks passed
@jensmaurer

jensmaurer commented Oct 24, 2025

Copy link
Copy Markdown
Member

@hanickadot You have admin rights for the org, and that gives you admin rights on every repository.

However, the textual contents of the C++ standard is the responsibility of the project editor. In his sole discretion, he has designated some individuals as co-editors (Jonathan and myself, I believe), and we've arranged for suitable two-manperson rules for committing changes to the working draft.

I am not aware that you have become co-editor (if so, please speak up), so I would ask you to refrain from merging anything at all into the working draft. Feel free to assign pull request to Thomas if you believe they're ready for merge, though.

@tkoeppe , FYI.

@hanickadot

Copy link
Copy Markdown
Contributor Author

Ah, sorry, I forgot about the two person rule.

@tkoeppe

tkoeppe commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Thank you, Jens! Indeed, @hanickadot, please don't commit anything to the main branch. I think this one is fine, but only the IS editors should commit here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants