[concept.regularinvocable], [iterator.concept.winc] Replace "annotation" with "comment"#8373
Merged
Merged
Conversation
…on" with "comment" Fixes NB US 71-128 (C++26 CD).
jwakely
approved these changes
Oct 29, 2025
Contributor
|
Thanks, that's a good improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NB US 71-128 (C++26 CD).
Fixes https://github.com/cplusplus/nbballot/issues/707.
The NB comment only asks to replace "annotation" with "comment", which makes sense considering that we have a language construct called "annotation" now.
I went a step further and copied the contents of this comment here. This seems helpful because you immediately understand what the contents of those comments are without having to navigate elsewhere.
Note that "not required to be equality-preserving" is a special comment used in a large number of places, defined in https://eel.is/c++draft/concepts.equality#4 My intuition was initially to use a Remarks element instead, but that would be too large of a change.