[simd.expos], [simd.syn] Synchronize synopsis references with subclause headings#8388
Conversation
|
I've asked @mattkretz about it, and he likes the longer comments for the "XXX permute" subclauses more. The direction for the initial version of the PR is to copy the subclause title as is. The default assumption should be that the subclause title is more authoritative. Also, we're not really consistent about referencing
I'd rather not innovate and just delete it all. We can always create prettier comments in a future version if that's a good use of our time. |
|
Yeah, I think there was some conflict between NB comments wanting longer headings, and our overall style of not repeating the class names in headings. I'll take a look later. |
|
The comments in the synopsis should exactly copy the subclause headings. Yes, those are short-ish. It looks like what this pull request attempts to do. I don't think SIMD is so special to warrant something different here. |
|
Indeed, and the NB comments may not have taken the wider context into consideration, so I think it's fine to accept "that we can improve things", but improve them in our own way. |
jensmaurer
left a comment
There was a problem hiding this comment.
So, it looks like we should just go ahead with this.
|
@eisenwave Could you please check your commit message(s)? I think there's a blank line missing after the first line, and I've seen this in several of your commits now. |
Fixes NB US 181-294 (C++26 CD).
|
@tkoeppe fixed. I wasn't even aware there's supposed to be a blank line because I've looked Jens' commits, and the GitHub web client doesn't render them (the difference only becomes visible in |
|
Thanks! I think this is some form of Git convention. (Emacs warns you if you have multiple lines and the second line isn't blank...) |
Fixes NB US 181-294 (C++26 CD).
Fixes https://github.com/cplusplus/nbballot/issues/869.