[cpp.pre] Add note on preprocessing directives in pp-global-module-fragment#8390
Open
AlisdairM wants to merge 1 commit into
Open
[cpp.pre] Add note on preprocessing directives in pp-global-module-fragment#8390AlisdairM wants to merge 1 commit into
AlisdairM wants to merge 1 commit into
Conversation
AlisdairM
changed the title
jensmaurer
reviewed
Nov 3, 2025
Contributor
|
@jensmaurer Did I get that right that you'd only want #8389 if we also merge this PR? |
Member
|
I've thought about this some more. I think the preprocessor treatment of the global module fragment is so surprisingly different from any other context that I would want to retain a cross-reference from phase 7 [module.global.frag] to [cpp.pre] in some form. This is a comment about #8389. And that would decouple those two pull requests. |
AlisdairM
force-pushed
the
add_note_to_clarify_pp_directives_in_pp_global
branch
from
3270875 to
46922ba
Compare
Add a note confirming that executing preprocessor directives within the pp-global-module-fragment can produce text-lines.
AlisdairM
force-pushed
the
add_note_to_clarify_pp_directives_in_pp_global
branch
from
46922ba to
fb96eb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note confirming that executing preprocessor directives within the pp-global-module-fragment can produce text-lines.