Skip to content

[lex] Complete the use of unicode code points#8412

Open
AlisdairM wants to merge 1 commit into
cplusplus:mainfrom
AlisdairM:unicodify_lex
Open

[lex] Complete the use of unicode code points#8412
AlisdairM wants to merge 1 commit into
cplusplus:mainfrom
AlisdairM:unicodify_lex

Conversation

@AlisdairM

@AlisdairM AlisdairM commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Completes the task of applying Unicode code point markup to
refer to single characters in normative text.

Replace all remaining uses of backslash as glyph () or text
with the corresponding unicode{005c}{reverse solidus} markup.

Replace a couple of text reference to single and double quotes
with their corresponding Unicode markup, and similarly for the
glyphs ` and ".

This should compete the last Unicode markup in [lex].

Resolves #5502

@eisenwave

Copy link
Copy Markdown
Member

Making this P2 because the direction affirmed for P2843R3 is that we ought to use code points instead of colloquial names like "backslash".

@eisenwave eisenwave added the P2-Bug Presentational errors and omissions label Nov 5, 2025
@tkoeppe tkoeppe requested a review from jensmaurer November 7, 2025 06:23
@tkoeppe

tkoeppe commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Could you reword the commit message to describe the change made by the commit, instead of the wider project (which isn't very descriptive)?

@jensmaurer

Copy link
Copy Markdown
Member

@AlisdairM , did you intend to close this?

@AlisdairM

Copy link
Copy Markdown
Contributor Author

No, I pushed an update that went to the wrong repo --- I am disconnected.

@jensmaurer

Copy link
Copy Markdown
Member

Ack. I had to make this repo private due to the other pull request about ongoing business, and that disconnected all forks. Quite a fall-out.

@tkoeppe tkoeppe reopened this Nov 10, 2025
@tkoeppe

tkoeppe commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

@AlisdairM: I reopened this.

@AlisdairM

Copy link
Copy Markdown
Contributor Author

I believe that this PR should be visible and open again, with the revised comment message that Thomas asked for, or at least my attempt at such a rewording.

@jensmaurer

Copy link
Copy Markdown
Member

Looks good, but the commit message needs a bit of work. "Complete X" is not descriptive of the actual changes made in this commit.

@jensmaurer jensmaurer added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Dec 6, 2025
@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 15, 2025
@tkoeppe

tkoeppe commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

@AlisdairM Please rebase

Completes the task of applying Unicode code point markup to
refer to single characters in normative text.

Replace all remaining uses of backslash as glyph (\) or text
with the corresponding `unicode{005c}{reverse solidus}` markup.

Replace a couple of text reference to single and double quotes
with their corresponding Unicode markup, and similarly for the
glyphs ` and ".

This should compete the last Unicode markup in [lex].
@AlisdairM

Copy link
Copy Markdown
Contributor Author

Rebased, and should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. needs rebase The pull request needs a git rebase to resolve merge conflicts. P2-Bug Presentational errors and omissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lex.pptoken] p2 Split the quotation characters into the corresponding terms

4 participants