[expr.const] Use different classes for unrelated parts of the example#8427
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
521adc3 to
254dc46
Compare
jensmaurer
approved these changes
Nov 5, 2025
Contributor
|
Can you please update both the commit description (as per https://github.com/cplusplus/draft/wiki/Commit-message-format) and the first post (state Note in particular that the commit message should not include any GitHub maintenance metadata. |
Member
|
For future pull requests, please see the help for the commit message format here: https://github.com/cplusplus/draft/wiki/Commit-message-format In this case, we want something like
The "fixes" or "resolves" for the github machinery only goes into the pull request description, not into the commit message. Please fix and force-push; thanks for your help! |
254dc46 to
10c0b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8425.