[meta.syn] Synchronize reflect_constant/reflect_object parameters with definition#8437
Merged
tkoeppe merged 1 commit intoNov 6, 2025
Conversation
Member
Author
|
Now looking at it, we also have at least one mismatch between the parameter names in the synopsis ( |
Member
|
Can you rename the function parameter in the synopsis to "expr" as well? Otherwise, looks good. |
bd56f25 to
08de7fd
Compare
reflect_constant parameter with definitionreflect_constant/reflect_object parameters with definition
katzdm
approved these changes
Nov 6, 2025
Contributor
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8244.
This synchronizes the function signature with the definition in https://eel.is/c++draft/meta.reflection.result#lib:reflect_constant
The paper author has confirmed that the CWG intent is for the parameter to be
T value; the use ofconst T&in the synopsis is an editorial oversight.