CWG Poll 3b: P3920R0 Wording for NB comment resolution on trivial relocation#8515
Conversation
Yes, please put those "Fixes NB..." lines into the commit message for posterity. And please do use the format specified here: https://github.com/cplusplus/draft/wiki/Commit-message-format#nb-comment-resolutions "git log" is your friend; we already have plenty of editorial ones. Otherwise looks good. |
1e93d2c to
801385c
Compare
|
For the commit description, thanks for adding the NB comments. "git log" shows that, historically, we have not repeated "NB" for each element in the list, and we've used ", and" between the penultimate and the last elements of the list. |
801385c to
dbbeeba
Compare
tkoeppe
changed the title
eisenwave
left a comment
eisenwave
left a comment
There was a problem hiding this comment.
Pretty sure it shouldn't be Also fixes but Fixes in the commit message, but Thomas can figure out the rest; the changes look correct.
Fixes NB BDS 2-034, CA 133, CA 136, CA 137, CN (write-in), FR 002-025, US 9-024, US 10-023, US 44-082, US 45-081, US 46-085, US 47-084, and US 73-131 (C++26 CD).
dbbeeba to
9ba98b1
Compare
4 participants
Also fixes BDS 2-034
Also fixes CA-133
Also fixes CA-136
Also fixes CA-137
Also fixes CN 6.9.1p9
Also fixes FR-002-025
Also fixes US 9-024
Also fixes US 10-023
Also fixes US 44-082
Also fixes US 45-081
Also fixes US 46-085
Also fixes US 47-084
Also fixes US 73-131
Fixes #8457
Fixes cplusplus/papers#2539
Also fixes cplusplus/nbballot#597
Also fixes cplusplus/nbballot#598
Also fixes cplusplus/nbballot#599
Also fixes cplusplus/nbballot#609
Also fixes cplusplus/nbballot#657
Also fixes cplusplus/nbballot#658
Also fixes cplusplus/nbballot#660
Also fixes cplusplus/nbballot#661
Also fixes cplusplus/nbballot#710
Also fixes cplusplus/nbballot#712
Also fixes cplusplus/nbballot#715
Also fixes cplusplus/nbballot#716
Also fixes cplusplus/nbballot#979