[cpp.cond] Keywords are not identifiers while preprocessing#8518
Merged
tkoeppe merged 2 commits intoDec 13, 2025
Conversation
jensmaurer
reviewed
Nov 14, 2025
AlisdairM
force-pushed
the
keywords_are_not_prepocessing_tokens
branch
from
November 17, 2025 08:07
d43a454 to
1df1072
Compare
hubert-reinterpretcast
left a comment
hubert-reinterpretcast
left a comment
Member
There was a problem hiding this comment.
I believe that the exception should be delimited by commas of a parenthetical nature.
jensmaurer
added
the
changes requested
Member
|
I think I like the overall outcome here. |
Co-authored-by: Hubert Tong <hubert.reinterpretcast@gmail.com>
jensmaurer
removed
the
changes requested
jensmaurer
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move seemingly normative reference to keywords in #if expressions into a note.