P3567R2 flat_meow fixes#8524
Conversation
|
There's no need for an issue, the intended design is clear: they should all be constexpr. Please just add constexpr keywords as a fixup commit. |
Yes, please. |
|
Alright, I've made them all |
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation and $M$ | ||
| is \tcode{ranges::distance(rg)}. |
There was a problem hiding this comment.
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation and $M$ | |
| is \tcode{ranges::distance(rg)}. | |
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation | |
| and $M$ is \tcode{ranges::distance(rg)}. |
(semantic break)
There was a problem hiding this comment.
The chosen line break is consistent with what we have further up for flat_map::insert and further below for flat_set::insert.
The and here is also a conjunction in a list, so it seems more appropriate to put it at the end of the line.
73480c2 to
b6d9c10
Compare
|
Should be all fixed now. Had to force-push because the second commit which adds |
7c5ad9d to
4d51701
Compare
These functions are not marked constexpr in P3567R2, but the intent of the (already merged) P3372R3 is to mark all member functions constexpr.
4d51701 to
1e42c87
Compare
Fixes #8463
No NB comment.
Also fixes cplusplus/papers#2211
PROBLEM: cplusplus/papers#2029 added
constexprto the members offlat_meow, but what we're merging doesn't have anyconstexpron it. LWG issue? @jwakely