P3663R3 Future-proof submdspan_mapping#8526
Conversation
That comment is asking to rename two things, one of which was added by this paper. This commit doesn't address that comment. |
| \tcode{SubExtents::rank()} equals the number of $k$ such that | ||
| $S_k$ does not model \tcode{\libconcept{convertible_to}<IndexType>}; and | ||
| \tcode{SubExtents::rank()} equals | ||
| \tcode{\exposid{MAP_RANK}(slices, Extents::rank())}; and |
There was a problem hiding this comment.
I think we have the same issue as above here with Extents::rank(). The existing text below says "for each rank index $k$ of \tcode{Extents}", so it may pay to introduce a name for the extents type. For example, we could change paragraph 1 like this
Let
Edenoteextents<IndexType, Extents...>, and letslicesbe the pack ....
and then use E throughout, e.g., in paragraph 2.
That being said, perhaps it's better just to merge the text as-is and then file an LWG issue with the above as a proposed fix. What do you think?
There was a problem hiding this comment.
That sounds too invasive to do as part of applying the paper.
mhoemmen
left a comment
mhoemmen
left a comment
There was a problem hiding this comment.
Thanks for doing the wording for this! : - )
| \tcode{M::index_type} | ||
| if the function is a member of a class \tcode{M}, | ||
| the declaration \tcode{auto [...ls] = std::move(s);} is well-formed | ||
| for some object \tcode{s} of type $S$, |
There was a problem hiding this comment.
S was not in math font in the paper, but I agree that it should be, as was done here.
There was a problem hiding this comment.
The paper requests a drive-by fix from layout_left to layout_right here, but that was already done in f2b0254
There was a problem hiding this comment.
The same commit also fixed _rank to rank_ as also requested by the paper.
There was a problem hiding this comment.
The paper also asks for two drive-by fixes here, which were already done by 82bf75b
This comment was marked as resolved.
This comment was marked as resolved.
6fa5971 to
81ab5be
Compare
81ab5be to
17b7576
Compare
Fixes NB PL-009, US 66-117 (C++26 CD).
17b7576 to
fd8cb30
Compare
5 participants
Fixes #8464
Fixes NB PL-009, US 66-117 (C++26 CD).
Also fixes cplusplus/papers#2292
Also fixes https://github.com/cplusplus/nbballot/issues/695
Also fixes https://github.com/cplusplus/nbballot/issues/818
Somehow relates to https://github.com/cplusplus/nbballot/issues/815 but I'm not sure how