Skip to content

P3371R5 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS#8550

Merged
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:motions-2025-11-lwg-20
Dec 15, 2025
Merged

P3371R5 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS#8550
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:motions-2025-11-lwg-20

Conversation

@eisenwave

Copy link
Copy Markdown
Member

Fixes #8479
Fixes NB US 168-277 (C++26 CD).

Also fixes cplusplus/papers#2028
Also fixes https://github.com/cplusplus/nbballot/issues/852

@eisenwave eisenwave added this to the post-2025-11 milestone Nov 17, 2025
@eisenwave
eisenwave force-pushed the motions-2025-11-lwg-20 branch 2 times, most recently from df99190 to d933aae Compare November 17, 2025 18:20
@eisenwave
eisenwave marked this pull request as ready for review November 17, 2025 18:23
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
@jwakely

jwakely commented Nov 28, 2025

Copy link
Copy Markdown
Member

Too late now, but this would have been much less difficult to review as two commits, one doing all the inout sub-word edits, and another adding and removing blocks of text 😢

Edit: three commits, even. One changing inout to in, one adding/removing blocks of text, and then one changing every "class Scalar" to "scalar Scalar", which needs to be done after adding the new functions.

Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated

@jwakely jwakely left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhoemmen please confirm that the new class Scalar template parameters being added by this paper should actually be scalar Scalar instead, since that's part of this paper, right?

Edit: yes, the editor's note at https://wiki.edg.com/pub/Wg21kona2025/StrawPolls/P3371R5.html#constrain-all-class-scalar-template-parameters says to rename all class Scalar to scalar Scalar after applying the changes from the paper. So the wording in the paper is "wrong" but the paper gives instructions for fixing it.

Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated

@jwakely jwakely left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paper has these line breaks in template parameter lists but they're unnecessary IMHO.

Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex Outdated
Comment thread source/numerics.tex
@jwakely

jwakely commented Nov 28, 2025

Copy link
Copy Markdown
Member

[Editorial Note: The changes proposed here are rebased atop the changes proposed in [LWG4137], “Fix Mandates, Preconditions, and Complexity elements of [linalg] algorithms.” – end note]

Are we going to get conflicts when the LWG issues from Kona are applied?

@eisenwave

This comment was marked as outdated.

eisenwave added a commit to eisenwave/draft that referenced this pull request Dec 13, 2025
@eisenwave

eisenwave commented Dec 13, 2025

Copy link
Copy Markdown
Member Author

Everything should be ready to merge now.

Are we going to get conflicts when the LWG issues from Kona are applied?

I'm not sure. It looks like the paper makes the exact same changes as LWG4137, so in theory, they will just be identical during merging, which git shouldn't see as a conflict.

@eisenwave
eisenwave requested a review from jwakely December 13, 2025 11:37
…pdates consistent with the BLAS

Fixes NB US 168-277 (C++26 CD).
@tkoeppe
tkoeppe force-pushed the motions-2025-11-lwg-20 branch from 5ff4c5a to 789ba10 Compare December 15, 2025 00:44
@tkoeppe
tkoeppe merged commit d4c759a into cplusplus:main Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants