[specialized.algorithms] Use \exposid for "voidify", not \placeholder(nc)#8566
Open
eisenwave wants to merge 2 commits into
Open
[specialized.algorithms] Use \exposid for "voidify", not \placeholder(nc)#8566eisenwave wants to merge 2 commits into
\exposid for "voidify", not \placeholder(nc)#8566eisenwave wants to merge 2 commits into
Conversation
eisenwave
added
after-motions
jwakely
approved these changes
Nov 27, 2025
jensmaurer
approved these changes
Nov 29, 2025
tkoeppe
reviewed
Dec 15, 2025
| make use of the following exposition-only function templates: | ||
| \begin{codeblock} | ||
| template<class T> | ||
| constexpr void* @\placeholdernc{voidify}@(T& obj) noexcept { |
Contributor
There was a problem hiding this comment.
could you retain the nc-ness (i.e. use \exposidnc where appropriate)?
Member
Author
There was a problem hiding this comment.
I don't think it's appropriate anywhere. Just below this change, we have deref-move without nc.
It doesn't seem like voidify is ever being vertically aligned with something else, and to my understanding, that's when we would disable italics corrections.
Member
There was a problem hiding this comment.
It's also for the spacing of (here) the parenthesis just after the italics.
eisenwave
force-pushed
the
voidify-exposid
branch
from
December 15, 2025 04:37
5ff8609 to
08ad45c
Compare
Member
Author
|
Rebased on latest |
eisenwave
removed
the
after-motions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8559.
This should be applied after motions; we're adding some more
\placeholdernc{voidify}these motions.A rebase will be needed.