Skip to content

[2026-03 CWG Motion 9] P3726R2 Adjustments to Union Lifetime Rules#8888

Merged
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:motions-2026-03-cwg-9
Apr 12, 2026
Merged

[2026-03 CWG Motion 9] P3726R2 Adjustments to Union Lifetime Rules#8888
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:motions-2026-03-cwg-9

Conversation

@eisenwave

@eisenwave eisenwave commented Mar 29, 2026

Copy link
Copy Markdown
Member

Fixes NB DE-087 (C++26 CD).
Fixes #8830

Also fixes cplusplus/papers#2356
Also fixes https://github.com/cplusplus/nbballot/issues/664
Also fixes cplusplus/papers#2418

@eisenwave eisenwave added this to the post-2026-03 milestone Mar 29, 2026
@brevzin

brevzin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Dunno if we also want to link the other NB comments here (which I forgot to mention in the paper):

  • US 48-086, which is marked a direct dupe of the German one.
  • FR-006-088, which actually asked to revert all of p3074
  • PL-003, which asked to just revert part of p3074 (which this paper does, but goes further).

@eisenwave eisenwave force-pushed the motions-2026-03-cwg-9 branch from b161010 to 597616d Compare March 30, 2026 19:15
@eisenwave

Copy link
Copy Markdown
Member Author

Dunno if we also want to link the other NB comments here (which I forgot to mention in the paper):

Thanks for the list. I'll leave that up to Thomas. I'm not sure if we want dupes and already closed issues to be referenced in the commit message and/or in the issue.

@jensmaurer

Copy link
Copy Markdown
Member

I think we want links to "accepted" NB comments in the commit and in the pull request where the commit contributes to resolving the NB comment. That also includes duplicates (because national bodies ostensibly don't know about each other's comment), but not "rejected; we're going in another direction" issues.

Comment thread source/basic.tex Outdated
Comment thread source/templates.tex Outdated
Comment thread source/support.tex
Comment thread source/memory.tex
@tkoeppe tkoeppe self-requested a review April 6, 2026 11:21
@tkoeppe

tkoeppe commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

I think we want links to "accepted" NB comments in the commit and in the pull request where the commit contributes to resolving the NB comment. That also includes duplicates (because national bodies ostensibly don't know about each other's comment), but not "rejected; we're going in another direction" issues.

Thanks! I added the duplicate comment to the commit message (but no Fixes link since it's already closed), and did not mention the comments that we reject.

@tkoeppe tkoeppe force-pushed the motions-2026-03-cwg-9 branch from f4a3002 to aaf83da Compare April 12, 2026 10:48
Fixes NB DE 087, US 48-086 (C++26 CD).

Editorial notes:
* Missing "freestanding" comment added to the feature test macro line.
* Removed "type" after "aggregate" (just "aggregate" is the right term).
@tkoeppe tkoeppe force-pushed the motions-2026-03-cwg-9 branch from aaf83da to 91648ff Compare April 12, 2026 11:46
@tkoeppe tkoeppe merged commit c8ca02b into cplusplus:main Apr 12, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants