[func.wrap.ref.ctor] Restore class T in constant_wrapper constructor head#9144
Merged
tkoeppe merged 1 commit intoJun 17, 2026
Conversation
…head The out-of-line declaration of the function_ref constructor taking a constant_wrapper<c, F> and a cv T* object pointer is headed with only template<auto c, class F>, but its function parameter (cv T* obj) and Constraints element (is-invocable-using<const F&, cv T*>) both name T, which is then undeclared. The class synopsis in [func.wrap.ref.class] already declares it as template<auto c, class F, class T>. Restore class T to the out-of-line head so it matches the synopsis.
eisenwave
added
the
P1-Important
jensmaurer
approved these changes
Jun 17, 2026
Contributor
|
Thanks! How was this lost in the first place... |
Contributor
|
Misapplication of P3948R1 via c8178e6. (Instead of adding |
Member
|
The good news is that P4206R0 (Brno LWG poll 5) doesn't touch this again, so won't conflict with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the missing
class Ttemplate parameter in the out-of-linefunction_refconstructor declaration so it matches the synopsis.