-
Notifications
You must be signed in to change notification settings - Fork 1
ci: add windows-latest to test matrix #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9f3b3c6
ci: add windows-latest to test matrix
clean6378-max-it cac3994
test(ci): polish Windows CI tests and matrix job names
clean6378-max-it a000e30
test: poll child started marker in msvcrt cross-process lock test
clean6378-max-it dd06045
test(ci): harden msvcrt lock test and document CI job overlap
clean6378-max-it 88bf398
test: hold export lock before spawning child in msvcrt test
clean6378-max-it f227c7b
fix(test): use Popen[bytes] annotation for msvcrt lock test
clean6378-max-it File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| """Tests for utils/session_path platform-specific home resolution.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| from utils import session_path | ||
|
|
||
|
|
||
| def test_get_claude_projects_dir_uses_userprofile_on_windows( | ||
| monkeypatch: pytest.MonkeyPatch, tmp_path: Path | ||
| ) -> None: | ||
| """Linux/Windows CI smoke: patch ``session_path.platform.system`` (needs ``import platform`` in module). | ||
|
|
||
| If ``session_path`` ever switches to ``from platform import system``, this patch | ||
| no-ops but may still pass on Linux via ``expanduser("~")``. Real Windows behavior | ||
| is covered by ``test_get_claude_projects_dir_on_windows_runner`` (win32-only). | ||
| """ | ||
| profile = tmp_path / "Users" / "testuser" | ||
| monkeypatch.setattr(session_path.platform, "system", lambda: "Windows") | ||
| monkeypatch.setenv("USERPROFILE", str(profile)) | ||
|
|
||
| got = session_path.get_claude_projects_dir() | ||
| assert got == os.path.join(str(profile), ".claude", "projects") | ||
|
|
||
|
|
||
| @pytest.mark.skipif(sys.platform != "win32", reason="native Windows runner") | ||
| def test_get_claude_projects_dir_on_windows_runner( | ||
| monkeypatch: pytest.MonkeyPatch, tmp_path: Path | ||
| ) -> None: | ||
| profile = tmp_path / "profile" | ||
| monkeypatch.setenv("USERPROFILE", str(profile)) | ||
|
|
||
| got = session_path.get_claude_projects_dir() | ||
| expected = os.path.join(str(profile), ".claude", "projects") | ||
| assert got == expected | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.