Remove mypy ignore_errors from CLI modules (#68 follow-up)

[bradjin8]

Summary

• Remove the remaining ignore_errors override for eight localci.cli.* modules in cli/pyproject.toml — completes the Remove mypy ignore_errors suppression across orchestrator/core modules #68 typing cleanup started in Remove mypy ignore_errors from orchestrator/core modules (#68) #72.
• Fix 17 strict mypy errors across CLI files (annotations, import paths, generic dicts, decorator typing).
• No runtime behavior changes.

Closes #76 .

Changes

Area	What
pyproject.toml	Delete CLI [[tool.mypy.overrides]] block; strict mypy now covers all localci packages
click_options.py	Apply click.pass_context outside the options list
status.py	dict[str, Any]; _safe_float uses isinstance narrowing
config.py	dict[str, Any] for YAML load
logs.py	_find_job → JobResult | None
patcher.py	PriorityJobQueue param on _print_execution_plan
analyze.py / list.py	Import WorkflowError from localci.errors
run_flow.py	Exception imports from localci.errors; Workflow/JobExecutor types; safe registry_path check
container.py	resolve_cache_paths_fn: Callable[..., ResolvedCachePaths | None]

Test plan

• cd cli && mypy localci/ — 48 files, 0 errors
• cd cli && pytest tests/ — 595 passed
• pre-commit run -a — all hooks green

Summary by CodeRabbit

• Bug Fixes
  • Improved command robustness across workflow, run, status, logs, and config commands.
  • Status output now handles invalid boolean values more safely.
  • Run-related command setup and execution flow now have better input handling and context wiring.
• Chores
  • Strengthened type checking coverage across the CLI, reducing the chance of regressions.

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

CLI strict typing and handling

Layer / File(s)	Summary
Strict mypy configuration cli/pyproject.toml	Strict checking now applies to all localci packages without legacy CLI error-suppression overrides.
Command module type contracts cli/localci/cli/analyze.py, config.py, list.py, logs.py	Imports and helper signatures now use explicit workflow, configuration, and job-result types.
Run flow typing and wrapping cli/localci/cli/run/*	Run decorators, dependencies, execution planning, registry-path handling, matrix helpers, and preflight execution use more specific types.
Status value handling cli/localci/cli/status.py	Status payloads receive explicit types, and _safe_float rejects booleans while handling numeric and string inputs explicitly.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

• cppalliance/local-ci-test-system issue 76 — Directly covers follow-up type-error cleanup in these CLI modules and removal of mypy overrides.

Possibly related PRs

• cppalliance/local-ci-test-system#36 — Introduces and standardizes the structured error types now imported by several CLI modules.
• cppalliance/local-ci-test-system#48 — Overlaps with the run decorator and cache-path dependency typing changes.
• cppalliance/local-ci-test-system#56 — Establishes strict mypy CI and related CLI override configuration.

Suggested reviewers: henry0816191, wpak-ai

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removing mypy ignore_errors for CLI modules as part of the typing cleanup.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/cli-mypy-strict

---

_{Comment @coderabbitai help to get the list of available commands.}