Skip to content

fixed #13895/13896/13897 - improved extension handling in platform lookup#7564

Merged
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:plat-ext
Jun 2, 2025
Merged

fixed #13895/13896/13897 - improved extension handling in platform lookup#7564
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:plat-ext

Conversation

@firewave

@firewave firewave commented Jun 1, 2025

Copy link
Copy Markdown
Collaborator
  • only append extension to platform if missing and fixed a case it was missing
  • do not look for extension-less platform files

@firewave

This comment was marked as resolved.

@firewave firewave changed the title fixed #13895/13896/13897 - improved extension handling in platform lookup [skip ci] fixed #13895/13896/13897 - improved extension handling in platform lookup Jun 1, 2025
…ng and fixed a case it was missing / do not look for extension-less platform files
@firewave firewave marked this pull request as ready for review June 2, 2025 07:57
@firewave

firewave commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator Author

@ludviggunne maybe also review since you worked on something related. Thanks.

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion we could allow extension-less platform files as far as I see.

@firewave

firewave commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator Author

I don't have a strong opinion we could allow extension-less platform files as far as I see.

See https://trac.cppcheck.net/ticket/12753 for some reasoning.

Do we have documentation of the lookup logic somewhere?

@ludviggunne

Copy link
Copy Markdown
Collaborator

@ludviggunne maybe also review since you worked on something related. Thanks.

LGTM, I think it makes sense to always use an extension for anything that's not plain text.

@ludviggunne

Copy link
Copy Markdown
Collaborator

Do we have documentation of the lookup logic somewhere?

I think this is the only info on custom platform files: https://github.com/danmar/cppcheck/blob/main/man/manual.md#platform

@firewave

firewave commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator Author

Do we have documentation of the lookup logic somewhere?

I think this is the only info on custom platform files: https://github.com/danmar/cppcheck/blob/main/man/manual.md#platform

Thanks. Will file a ticket and add/update it when the code is mostly aligned.

@firewave firewave merged commit f6bd94f into cppcheck-opensource:main Jun 2, 2025
56 of 57 checks passed
@firewave firewave deleted the plat-ext branch June 2, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants