-
Notifications
You must be signed in to change notification settings - Fork 70
this module makes me so outraged and stupid. why do you export details functions and other junk? It completely breaks on wasm #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, it avoids the issue with end()+0 on an empty() deque which is currently would dereference UB pointer. Second, it should also help reduce cache misses since the + - etc would move inside a block itself. We will do it later on.
with fast path. also to test the performance of []
works as random access iterator
…row_back_common so that push_back/front and insert can share code
that shares with insert. all these useless garbage will be removed after the container finishes
overlapped_copy only works for trivially_copyable types
implement deque iterator relocate and relocate_backward
remove threading junk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is NOT your project @MacroModel