Hard-cut review profiles to the current engine contract - #251
Merged
Conversation
forhappy
marked this pull request as ready for review
August 14, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Review used Compass release numbers as a proxy for profile compatibility. It also bypassed current-engine reconstruction when both revisions already had preferred realizations, especially when their profiles matched. A globally applied preferred-profile check then risked making read-only historical query and export rebuild selected history under mutable repository configuration.
Contract policy
Normal review does not parse, order, or allowlist a persisted Compass release string. It reconstructs the profile under the current engine and validates the actual supported option contract. If that profile shape changes in the future, Compass should hard-cut to the new contract and reject unsupported shapes rather than add release-specific migrations.
Compass version remains in the extraction fingerprint as engine provenance. Exact fingerprint comparisons and queued materialization profiles retain strict identity checks; these are integrity checks, not release compatibility policy. Binary self-update semver selection is unrelated and remains intact.
User impact
Compass review rebuilds a current comparable pair whenever persisted user options remain supported and identical, regardless of the persisted engine-version text. Historical realizations remain immutable and queryable. Different user options or unsupported shapes fail explicitly.
Verification