Skip to content

fix: allow in-scope symlinked skill destinations - #253

Merged
forhappy merged 1 commit into
mainfrom
codex/fix-symlinked-skill-destination
Aug 15, 2026
Merged

fix: allow in-scope symlinked skill destinations#253
forhappy merged 1 commit into
mainfrom
codex/fix-symlinked-skill-destination

Conversation

@forhappy

Copy link
Copy Markdown
Contributor

Summary

  • Allow skill destinations to traverse symlinked parent directories when the fully resolved target remains inside the selected scope.
  • Continue rejecting symlink escapes outside the project or configured scope.
  • Add CLI regression coverage for the reported .claude/skills -> ../.agents/skills layout and out-of-scope links.

Root cause

validate_skill_destination rejected every symbolic-link ancestor before checking where it resolved. This blocked legitimate project-local skill layouts such as the reported Claude link.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --lib --bins --locked -- -D warnings
  • cargo test -p compass-cli --test install_cli --locked (26 passed)
  • cargo test -p compass-cli --test compass_product --locked (8 passed)
  • cargo test --workspace --lib --bins --locked
  • sh scripts/check_product_boundary.sh

@forhappy
forhappy marked this pull request as ready for review August 15, 2026 22:56
@forhappy
forhappy merged commit 3d2ac12 into main Aug 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant