Harden graph diagnostics and PHP publication semantics - #256
Merged
Conversation
forhappy
marked this pull request as ready for review
August 16, 2026 03:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the recommended graph-analysis priorities and preserve PHP semantics that the canonical v1 publisher previously lost:
compass.graph-insights/1projection inanalysis.json, optionalcompass.orientation/2,GRAPH_REPORT.md, and the read-only MCP resourcecompass://graph-insights.compass history blind-spots, including active/resolved findings and explicit missing-sidecar observations.closurenodes.mixes_ininstead of collapsing it intoimplements.Root cause and impact
The PHP extractor and resolver already emitted closure declarations and exact trait-use evidence. The
compass.graph/1publication vocabulary did not recognizeclosure, so it quarantined those nodes and their relationships. It also normalizedmixes_intoimplements, losing the distinction between trait composition and interface conformance.On the Laravel Framework corpus, the corrected publisher produces 57,202 nodes and 118,646 edges, including 9,227 closures and 1,110
mixes_inrelationships, with zero publication omissions or identity collisions. The unchanged warm run reused all 3,083 files in 2.84 seconds and reproduced the identical graph hash.Contract and behavior
compass.orientation/1tocompass.orientation/2; older orientation files must be regenerated.compass.graph/1;closureandmixes_inare additive typed vocabulary entries.Validation
cargo fmt --all -- --checkcargo clippy --workspace --lib --bins --locked -- -D warningscargo test --workspace --lib --bins --locked./scripts/qualify_code_graph_v1.sh --fixtures-onlysh scripts/check_product_boundary.shgit diff --check