⚡ Bolt: Optimize Job Event Sequence Number Calculation - #151
Conversation
Replaces inefficient list loading for sequence generation with direct SQL aggregation in `get_max_sequence_no` across api, parse, evaluation, knowledge, and synthesis services. Co-authored-by: crabcanon <3458947+crabcanon@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Introduced a
get_max_sequence_nomethod inJobEventRepositoryto fetch the maximum sequence directly via SQL aggregation (COALESCE(MAX(sequence_no), 0)), and refactored multiple services (API cancellation, Evaluation, Knowledge, Parse, and Synthesis jobs) to use this instead of loading large lists.🎯 Why: The previous logic (
list_for_job(job_id, limit=1000)) unnecessarily loaded up to 1000 events into application memory just to check the last record's sequence number and increment it by 1. This mimics N+1 query inefficiencies and adds substantial memory overhead as jobs become highly active.📊 Impact: Reduces memory overhead from O(N) (up to 1000 objects per check) to O(1) for highly active jobs when calculating the next sequence number.
🔬 Measurement: Verified via unit test passes and checking local database logs to see
SELECT MAX()executing efficiently.PR created automatically by Jules for task 3575120586055538275 started by @crabcanon