remember the invalid nested element ids too#18690
Merged
brandonkelly merged 3 commits into5.xfrom Apr 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the draft couldn’t be applied, we still save it, so that we don’t lose any content, and we “remember” the validation errors from before the draft was saved.
This PR ensures that the invalid nested element IDs are also “remembered”. This ensures that, e.g. the relevant nested element can be visually marked as invalid.
Steps to reproduce:
Before this PR: the relevant card didn’t have the indicators showing that it’s invalid (red title and an exclamation mark icon).
After this PR: the indicators are there
Related issues
n/a