get nested elements for all localised owners#18702
Merged
brandonkelly merged 3 commits into5.xfrom Apr 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In v5.9.0, the before prepare element query for matrix field started calling
$query->owner($owner)as opposed to$query->ownerId = $owner->id(686acd93cc#diff-b69a116794c7e46c0ab7429df36ab933f3ff5071e8e1856aa27cf9de2c4b1b40L778).This change made significant performance improvements, but it looks like it has some adverse effects when combined with certain propagation settings. The
NestedElementQueryTrait::owner()method will set the query’ssiteIdto the owner’ssiteIdand ignore any othersiteIdparam that was previously configured on the query.In the case described by OP, it means that when creating revisions, the nested elements are only found on the owner’s site, and any nested elements unique to other sites supported by the owner are ignored.
Fix:
When getting nested elements in the
NestedElementManager::createRevisions()method, first get the owner element across all supported sites, then get the nested elements for each site individually.Related issues
#18691