Skip to content

[8844] FE2 - back to top button not working - #8845

Open
jvega190 wants to merge 1 commit into
craftersoftware:developfrom
jvega190:bugfix/8844
Open

[8844] FE2 - back to top button not working#8845
jvega190 wants to merge 1 commit into
craftersoftware:developfrom
jvega190:bugfix/8844

Conversation

@jvega190

@jvega190 jvega190 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

#8844

Summary by CodeRabbit

  • Bug Fixes
    • Improved the “Back to top” button to scroll the form’s main content area reliably.
    • Added more accurate detection of the form’s scrolling container, with a fallback for compatibility.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Forms Engine marks its main content container, updates scroll-container resolution to prefer that element, and makes the back-to-top component use the shared resolver directly.

Changes

Forms Engine scrolling

Layer / File(s) Summary
Resolve the form main content scroll target
studio-ui/ui/app/src/components/FormsEngine/components/FormLayout.tsx, studio-ui/ui/app/src/components/FormsEngine/lib/formUtils.tsx, studio-ui/ui/app/src/components/FormsEngine/components/FormBackToTop.tsx
The main content container is marked with data-area-id="formMainContent", getScrollContainer resolves that element when present, and FormBackToTop uses the shared helper without accepting a callback prop.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Suggested reviewers: jmendeza

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only links an issue and omits the required template heading and summary of the change. Add the required section heading and a brief summary of the change, scope, and any testing or impact notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the fixed issue and matches the back-to-top button change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jvega190
jvega190 marked this pull request as ready for review July 30, 2026 14:56
@jvega190
jvega190 requested a review from rart July 30, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant