Skip to content

[8095] Add sorting to pages DS, fix sort not applying - #8918

Draft
jvega190 wants to merge 1 commit into
craftersoftware:developfrom
jvega190:enhancement/8095
Draft

[8095] Add sorting to pages DS, fix sort not applying#8918
jvega190 wants to merge 1 commit into
craftersoftware:developfrom
jvega190:enhancement/8095

Conversation

@jvega190

@jvega190 jvega190 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

#8095

Summary by CodeRabbit

  • New Features
    • Added sorting options for Pages data sources, including sort field and sort order.
    • Browse and search results now apply the selected sorting preferences while preserving MIME-type filters.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 11a61995-6076-4669-858c-bd4d76cb0247

📥 Commits

Reviewing files that changed from the base of the PR and between b75677b and 5994c5c.

📒 Files selected for processing (2)
  • studio-ui/ui/app/src/components/ContentTypeManagement/descriptors/dataSources/pages.ts
  • studio-ui/ui/app/src/components/FormsEngine/dataSources/moduleHelpers.ts

Included review availability: 4 reviews are currently available. Based on recent review activity, included reviews refill at 5 per hour.


Walkthrough

The Pages data source descriptor now exposes sorting fields. Browse and search actions forward the configured sorting parameters to their data-source services.

Changes

Pages data-source sorting

Layer / File(s) Summary
Pages sorting contract
studio-ui/ui/app/src/components/ContentTypeManagement/descriptors/dataSources/pages.ts
The Pages descriptor exposes sortBy and sortOrder as sort dropdowns with defaults and sort metadata.
Sorting request propagation
studio-ui/ui/app/src/components/FormsEngine/dataSources/moduleHelpers.ts
Browse and search actions include sortBy and sortOrder in initialParameters. Search continues to apply MIME-type filters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5994c

This localized change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant PagesDataSourceDescriptor
  participant BrowseSearchActions
  participant DataSourceServices
  PagesDataSourceDescriptor->>BrowseSearchActions: provide sortBy and sortOrder metadata
  BrowseSearchActions->>DataSourceServices: send sortBy and sortOrder in initialParameters
Loading

Possibly related PRs

Suggested labels: FE 2

Suggested reviewers: jmendeza

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Pages data source sorting change and the fix for sort application.
Description check ✅ Passed The description provides the required ticket reference, and the PR objectives provide additional context about the changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jvega190

Copy link
Copy Markdown
Contributor Author

@coderabbitai how does this work look to be merged? Any issues you can point out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant