This repository was archived by the owner on Apr 6, 2025. It is now read-only.
Add JS that toggles class on HTML indicating availability of JS.#3
Open
stephaniehobson wants to merge 1 commit into
Open
Add JS that toggles class on HTML indicating availability of JS.#3stephaniehobson wants to merge 1 commit into
stephaniehobson wants to merge 1 commit into
Conversation
Owner
|
I'm hesitant to add embedded JS. It's justified in this instance but if this is going to evolve into a set of starter templates and markup patterns that serve as examples of best practices, I'm worried about setting a precedent. That could be addressed by documentation, I suppose. Or we can move it to an external "global.js" file to serve as a starting point for any other global functions someone might want to execute on every page. Of course, moving it external can bring back the FOUC, depending on how the .no-js class gets used. Or maybe we should just lose the whole .no-js/.js business entirely, at least for this framework. It's a sound methodology when called for, but maybe we just don't need it built into the boilerplate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to the head to avoid FOUC, just needs to have element to run so doesn't need to wait for DOM ready. Used same class as Bedrock.