Adapter docs for convention-breakers#29
Open
TheDeveloper wants to merge 2 commits intocreationix:masterfrom
Open
Adapter docs for convention-breakers#29TheDeveloper wants to merge 2 commits intocreationix:masterfrom
TheDeveloper wants to merge 2 commits intocreationix:masterfrom
Conversation
Owner
|
Good idea, but using the inline self-calling function is terribly confusing. |
Author
|
True - I've clarified it a bit. Untested but should work. |
Owner
|
Better would be to simply convert the function to be node-style without involving step at all. I don't like using bind to insert step's "this" into the wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought this could be useful when using Step with libraries that don't observe the callback(err,res) convention.
Wdyt?