Update React to 19 by nmoskaleva · Pull Request #287 · criipto/docs

nmoskaleva · 2026-02-05T20:40:28Z

QA: Please verify that everything looks as expected, specifically the styles in the Signatures interactive tours.

netlify · 2026-02-05T20:40:34Z

✅ Deploy Preview for criipto-docs ready!

Name	Link
🔨 Latest commit	`432c263`
🔍 Latest deploy log	https://app.netlify.com/projects/criipto-docs/deploys/6989b212ca69880008822cc1
😎 Deploy Preview	https://deploy-preview-287--criipto-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nmoskaleva · 2026-02-05T21:30:10Z

Looks like @sentry/gatsby doesn't support React 19 yet (10.38.0 is the latest version).
This branch works locally when installing with --legacy-peer-deps.

nmoskaleva · 2026-02-06T23:12:46Z

gatsby-browser.tsx

 import '@fontsource/ibm-plex-sans/600.css';
 import '@fontsource/ibm-plex-sans/700.css';
 import '@fontsource/ibm-plex-mono/400.css';
-import 'graphiql/graphiql.min.css';


Moved this import to global.css, otherwise the styles were not applied in the interactive tours.

nmoskaleva · 2026-02-06T23:15:21Z

src/components/WebhookSignatureValidator.tsx

+function base64ToArrayBuffer(base64: string): ArrayBuffer {
+  const binaryString = window.atob(base64);
+  const bytes = new Uint8Array(binaryString.length);
+  for (let i = 0; i < binaryString.length; i++){
    bytes[i] = binaryString.charCodeAt(i);
  }
-  return bytes;
+  return bytes.buffer;
 }


TypeScript inferred the old Uint8Array as an invalid BufferSource.

mickhansen · 2026-02-09T08:27:32Z

src/layouts/default.tsx

-  isIduraBannerVisible: boolean;
-  onCloseBanner: () => void;
+  isIduraBannerVisible?: boolean;
+  onCloseBanner?: () => void;


A bit of an unrelated change, I know. But the two required props were causing a TS error in gatsby-browser.tsx which was changed in this PR, so I assumed it's acceptable. I'll move it to a separate commit.

@nmoskaleva Of course acceptable, just good to document why, in a separate commit :)

mickhansen · 2026-02-09T08:29:24Z

Schema explorer looks & behaves as expected.
Explorer looks & behaves as expected
Interactive tour looks & behaves as expected.
Docs look good in general.

Make isIduraBannerVisible and onCloseBanner optional to avoid TS errors when <DefaultLayout/> is used without the Idura banner.

mickhansen · 2026-02-09T09:02:30Z

CI errors https://github.com/criipto/docs/actions/runs/21818586784/job/62945860970

nmoskaleva · 2026-02-09T09:03:28Z

@mickhansen just a sec, rebase didn't go exactly as I was hoping, but I know what's wrong.

mickhansen · 2026-02-09T09:19:08Z

src/components/WebhookSignatureValidator.tsx

    bytes[i] = binaryString.charCodeAt(i);
  }
-  return bytes;
+  return bytes.buffer;


Not sure why this is required? subtle should support a typed array: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/importKey

I'm also not sure why, but after updating to React 19, there is a build error without this change @mickhansen

@nmoskaleva What's the error? I don't see how React could influence the use of core browser APIs

No overload matches this call. Overload 1 of 2, '(format: "jwk", keyData: JsonWebKey, algorithm: AlgorithmIdentifier | RsaHashedImportParams | EcKeyImportParams | HmacImportParams | AesKeyAlgorithm, extractable: boolean, keyUsages: readonly KeyUsage[]): Promise<...>', gave the following error. Argument of type '"raw"' is not assignable to parameter of type '"jwk"'. Overload 2 of 2, '(format: "raw" | "pkcs8" | "spki", keyData: BufferSource, algorithm: AlgorithmIdentifier | RsaHashedImportParams | EcKeyImportParams | HmacImportParams | AesKeyAlgorithm, extractable: boolean, keyUsages: KeyUsage[]): Promise<...>', gave the following error. Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'. Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'. Types of property 'buffer' are incompatible. Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'. Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength

For some reason, the same error didn't appear in checks now. But when you noticed CI errors earlier today – it was due to the fact I lost this commit.
I see the error in my code editor now, and pretty sure it might appear again once other check errors are fixed... @mickhansen

@nmoskaleva Hmm OK, strange.

haysch

Overall docs look as expected.
Signatures explorer and schema still works as expected.
The available Signatures Interactive tour also looks and works as expected (an error in TSA server in test means I cannot complete the tour by closing the order).

… to ArrayBuffer TypeScript inferred the old Uint8Array<ArrayBufferLike> as invalid BufferSource. Using ArrayBuffer fixes this.

nmoskaleva changed the title ~~Update react to 19~~ Update React to 19 Feb 5, 2026

nmoskaleva marked this pull request as draft February 5, 2026 20:41

nmoskaleva force-pushed the update-react-to-19 branch 2 times, most recently from e002744 to d855079 Compare February 5, 2026 21:29

nmoskaleva force-pushed the update-react-to-19 branch 7 times, most recently from 9d13a69 to bcecc2d Compare February 6, 2026 22:51

nmoskaleva marked this pull request as ready for review February 6, 2026 22:53

nmoskaleva commented Feb 6, 2026

View reviewed changes

nmoskaleva requested a review from mickhansen February 9, 2026 08:25

mickhansen requested a review from haysch February 9, 2026 08:27

mickhansen reviewed Feb 9, 2026

View reviewed changes

nmoskaleva added 4 commits February 9, 2026 09:57

Fix DefaultLayout banner props typing

aa885e7

Make isIduraBannerVisible and onCloseBanner optional to avoid TS errors when <DefaultLayout/> is used without the Idura banner.

Upgrade @sentry/gatsby from v7 to v10

d9dd50d

Update @FortAwesome packages

bceedee

Update gatsby and graphiql

61964f5

nmoskaleva force-pushed the update-react-to-19 branch from bcecc2d to 532fd85 Compare February 9, 2026 08:59

mickhansen reviewed Feb 9, 2026

View reviewed changes

nmoskaleva force-pushed the update-react-to-19 branch from 7ddb521 to 1dbfc06 Compare February 9, 2026 09:28

haysch reviewed Feb 9, 2026

View reviewed changes

nmoskaleva force-pushed the update-react-to-19 branch from 1dbfc06 to 4457ff3 Compare February 9, 2026 09:50

nmoskaleva added 2 commits February 9, 2026 11:06

Fix webcrypto importKey TS overload error by converting base64 secret…

dfc9245

… to ArrayBuffer TypeScript inferred the old Uint8Array<ArrayBufferLike> as invalid BufferSource. Using ArrayBuffer fixes this.

Update React to 19

432c263

nmoskaleva force-pushed the update-react-to-19 branch from 4457ff3 to 432c263 Compare February 9, 2026 10:08

Conversation

nmoskaleva commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for criipto-docs ready!

Uh oh!

nmoskaleva commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickhansen commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mickhansen commented Feb 9, 2026

Uh oh!

nmoskaleva commented Feb 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nmoskaleva Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haysch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nmoskaleva commented Feb 5, 2026 •

edited

Loading

netlify bot commented Feb 5, 2026 •

edited

Loading

mickhansen commented Feb 9, 2026 •

edited

Loading

nmoskaleva Feb 9, 2026 •

edited

Loading