fix(twitter): show sensitive media #1572 - #1605
Conversation
The previous JSON was ignored, now it use JsonTweetWithVisibilityResults where the media_visibility_results object is removed so there are no visibility limits
|
Tested on version 12.11 |
|
|
||
| methods.addInstructions( | ||
| returnObj, | ||
| val method = sensitiveMediaSettingsPatchFingerprint.method |
There was a problem hiding this comment.
I feel like it would be better if we hook the parse method like we have done for timeline items and handle the fields on java rather than in smali.
There was a problem hiding this comment.
Which fields?
There are no fields to edit but just avoid loading a part of the JSON.
The old fields are no longer used by the current version of X.
Much of the code is left but is not being executed.
There was a problem hiding this comment.
I can restore the code inside TimelineEntry and change the sensitiveMedia method so that it returns to a boolean and then inside the JsonTweetWithVisibilityResults$$JsonObjectMapper class, verify that boolean to enable or not the loading of media_visibility_results from TweetWithVisibilityResults.
2 participants
Fix the issue "show sensitive media" in #1572, for "Remove premium upsell" there is already a fix in 3.9.0-dev.1