Skip to content

Include buffering time in read statistics for non-seekable streams #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaunWatsonCrisp merged 2 commits into from
Mar 4, 2026
Merged

Include buffering time in read statistics for non-seekable streams #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09bf746
Initial plan
Copilot Mar 4, 2026
d64fd2f
Include buffering time in ReadDuration for non-seekable streams
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/PdqHash/PdqHasher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,16 @@ private static void ComputeDCTMatrix(Memory<float> memory)

public HashResult? FromStream(Stream input, string source)
{
if (!input.CanSeek)
var stopwatch = Stopwatch.StartNew();

using var bufferedStream = input.CanSeek ? null : new MemoryStream();
if (bufferedStream != null)
{
using var buffered = new MemoryStream();
input.CopyTo(buffered);
buffered.Position = 0;
return FromStream(buffered, source);
input.CopyTo(bufferedStream);
bufferedStream.Position = 0;
input = bufferedStream;
}

var stopwatch = Stopwatch.StartNew();

using var codec = SKCodec.Create(input, out var result);

if (codec == null)
Expand Down