Per-Request Auth Token Refresh by carlpatchett · Pull Request #103 · crispthinking/athena-python-client

carlpatchett · 2026-02-16T12:09:04Z

Token is now not eagerly pulled and baked into requests, its dynamically aquired per rpc

…ed tests

src/resolver_athena_client/client/channel.py

Copilot

Pull request overview

This PR implements dynamic token refresh for OAuth authentication by deferring token acquisition from channel creation time to per-RPC invocation. The implementation changes from async to sync I/O to accommodate gRPC's threading model and switches the authorization header format from "Token" to the standard "Bearer" prefix.

Changes:

Token acquisition now occurs dynamically per RPC instead of eagerly at channel creation time
Converted CredentialHelper from async/await to synchronous with threading.Lock for gRPC callback compatibility
Changed authorization header format from "Token {token}" to standard "Bearer {token}"

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/resolver_athena_client/client/channel.py	Removed TokenMetadataPlugin, added _AutoRefreshTokenAuthMetadataPlugin for dynamic token refresh; converted CredentialHelper from async to sync; changed authorization scheme to Bearer
tests/client/test_channel.py	Updated tests to verify non-eager token fetching; converted async tests to sync; added tests for new _AutoRefreshTokenAuthMetadataPlugin class
tests/functional/conftest.py	Removed eager token acquisition test from credential_helper fixture
examples/example.py	Removed eager token acquisition and validation before channel creation
examples/classify_single_example.py	Removed eager token acquisition and validation before channel creation
docs/authentication.rst	Updated code examples to reflect that get_token() is now synchronous
docs/api/exceptions.rst	Updated code examples to reflect that get_token() is now synchronous

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/resolver_athena_client/client/channel.py

iwillspeak

LGTM

src/resolver_athena_client/client/channel.py

…only scanning relevant files

Copilot · 2026-02-20T10:42:08Z

@iwillspeak I've opened a new pull request, #107, to work on those changes. Once the pull request is ready, I'll request review from you.

iwillspeak · 2026-02-20T10:49:03Z

@copilot looks like the changes in #106 have broken some of the tests. Update the tests to match the expected behaviour with schemes (we always respect the capitalisation from the server)

Copilot · 2026-02-20T10:49:12Z

@iwillspeak I've opened a new pull request, #108, to work on those changes. Once the pull request is ready, I'll request review from you.

pyproject.toml

src/resolver_athena_client/client/channel.py

… for pyright

…stampede (#107) * Initial plan * Implement background token refresh for old tokens - Add issued_at field to TokenData to track token creation time - Add is_old() method to check if token should be refreshed (< 50% lifetime) - Trigger non-blocking background refresh when token is old but valid - Keep blocking refresh for expired tokens - Add comprehensive tests for background refresh behavior Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> * fix: update tests to match preserved token scheme casing Tests were expecting capitalized schemes but implementation was changed in 4b7e73a to preserve server-provided casing. Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> * Address code review feedback - Add logging for background refresh failures - Improve comments explaining magic numbers - Add test for server casing preservation - Add comment explaining test tolerance Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> * Address PR review comments - Make issued_at a required field (remove default value) - Remove fallback logic for legacy tokens in is_old() - Add stampede prevention in _background_refresh - Remove obsolete tests for fallback logic - Add test for stampede prevention Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> * Revert Bearer/DPoP test assertion changes from c50327d The target branch now properly fixes the test by providing "Bearer" in the mock data. Reverting my previous fix that changed the assertion to match the old mock data. Co-authored-by: anna-singleton-resolver <199753965+anna-singleton-resolver@users.noreply.github.com> * fix: start refresh thread checks for already refreshed token * chore: remove extraneous comment * feat: reduce eagerness of background refresh from at 50% remaining to 25% remaining * doc: update is_old docstring * fix: correct boolean logic in _start_background_refresh Changed from OR to AND logic: refresh should start if (refresh_not_active AND token_needs_refresh), not if any condition is true. This prevents unnecessary refresh attempts. Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> * test: fix test assertions to be on 25% instead of 50% * feat: allow configurable proactive_refresh_threshold --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: iwillspeak <1004401+iwillspeak@users.noreply.github.com> Co-authored-by: anna-singleton-resolver <199753965+anna-singleton-resolver@users.noreply.github.com> Co-authored-by: anna-singleton-resolver <anna.singleton@resolver.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/client/test_channel.py

src/resolver_athena_client/client/channel.py

…init

src/resolver_athena_client/client/channel.py

refactor: simplify token acquisition by removing async calls and unus…

878b19e

…ed tests

carlpatchett temporarily deployed to pypi February 17, 2026 09:29 — with GitHub Actions Inactive

snus-kin requested a review from Copilot February 17, 2026 09:30

Copilot started reviewing on behalf of snus-kin February 17, 2026 09:31 View session

iwillspeak suggested changes Feb 17, 2026

View reviewed changes

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

iwillspeak mentioned this pull request Feb 17, 2026

fix: use the refresh code for oauth token #88

Closed

Copilot AI reviewed Feb 17, 2026

View reviewed changes

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

iwillspeak changed the title ~~Dynamic Refresh~~ Dynamic Auth Token Refresh Feb 17, 2026

iwillspeak changed the title ~~Dynamic Auth Token Refresh~~ Per-Request Auth Token Refresh Feb 17, 2026

Introduce TokenData class

8ab55e1

carlpatchett temporarily deployed to pypi February 17, 2026 13:28 — with GitHub Actions Inactive

iwillspeak previously approved these changes Feb 17, 2026

View reviewed changes

snus-kin requested changes Feb 17, 2026

View reviewed changes

src/resolver_athena_client/client/channel.py Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

Passing () to avoid type checking problems

9ab122c

carlpatchett dismissed iwillspeak’s stale review via 9ab122c February 17, 2026 14:54

carlpatchett temporarily deployed to pypi February 17, 2026 14:55 — with GitHub Actions Inactive

snus-kin previously approved these changes Feb 17, 2026

View reviewed changes

Merge branch 'main' into feature/dynamic-refresh

f3d67d7

carlpatchett temporarily deployed to pypi February 18, 2026 09:33 — with GitHub Actions Inactive

anna-singleton-resolver previously approved these changes Feb 18, 2026

View reviewed changes

JohnnyWombwell previously approved these changes Feb 18, 2026

View reviewed changes

iwillspeak previously approved these changes Feb 18, 2026

View reviewed changes

Test fixups

1b3e2a2

carlpatchett dismissed stale reviews from iwillspeak, JohnnyWombwell, anna-singleton-resolver, and snus-kin via 1b3e2a2 February 18, 2026 15:27

fix: update test cases to suppress unused return value warnings, now …

60032d8

…only scanning relevant files

carlpatchett temporarily deployed to pypi February 18, 2026 16:29 — with GitHub Actions Inactive

iwillspeak previously approved these changes Feb 19, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 20, 2026

Address review feedback: require issued_at field and prevent refresh stampede #107

Merged

Copilot AI mentioned this pull request Feb 20, 2026

Fix test expectations for server-provided token scheme casing #108

Closed

snus-kin requested changes Feb 20, 2026

View reviewed changes

anna-singleton-resolver added 3 commits February 20, 2026 14:27

chore: remove 'include' and revert removal of .venv from exclude list…

a7a7286

… for pyright

chore: remove some extraneous comments

52e8b00

test: consistent casing in assertions and provided mock data

0c7c3b9

anna-singleton-resolver temporarily deployed to pypi February 20, 2026 14:42 — with GitHub Actions Inactive

anna-singleton-resolver requested review from iwillspeak and snus-kin February 20, 2026 15:23

anna-singleton-resolver temporarily deployed to pypi February 23, 2026 10:45 — with GitHub Actions Inactive

anna-singleton-resolver requested a review from Copilot February 23, 2026 10:49

Copilot started reviewing on behalf of anna-singleton-resolver February 23, 2026 10:49 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

tests/client/test_channel.py Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

iwillspeak previously approved these changes Feb 23, 2026

View reviewed changes

snus-kin requested changes Feb 23, 2026

View reviewed changes

src/resolver_athena_client/client/channel.py Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

src/resolver_athena_client/client/channel.py Show resolved Hide resolved

refactor: TokenData as frozen dataclass and param validity checks at …

05597ca

…init

anna-singleton-resolver dismissed iwillspeak’s stale review via 05597ca February 23, 2026 11:38

anna-singleton-resolver temporarily deployed to pypi February 23, 2026 11:39 — with GitHub Actions Inactive

doc: remove old part of docstring

3cff677

snus-kin reviewed Feb 23, 2026

View reviewed changes

src/resolver_athena_client/client/channel.py Outdated Show resolved Hide resolved

anna-singleton-resolver temporarily deployed to pypi February 23, 2026 11:49 — with GitHub Actions Inactive

snus-kin approved these changes Feb 23, 2026

View reviewed changes

anna-singleton-resolver enabled auto-merge (squash) February 23, 2026 11:51

iwillspeak approved these changes Feb 23, 2026

View reviewed changes

anna-singleton-resolver merged commit 3d9e87f into main Feb 23, 2026
17 checks passed

anna-singleton-resolver deleted the feature/dynamic-refresh branch February 23, 2026 11:53

Conversation

carlpatchett commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iwillspeak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 20, 2026

Uh oh!

iwillspeak commented Feb 20, 2026

Uh oh!

Copilot AI commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

carlpatchett commented Feb 16, 2026 •

edited

Loading