Skip to content

feat: configurable e2e test cases#116

Closed
anna-singleton-resolver wants to merge 3 commits intomainfrom
feature/pick-e2e-testcases
Closed

feat: configurable e2e test cases#116
anna-singleton-resolver wants to merge 3 commits intomainfrom
feature/pick-e2e-testcases

Conversation

@anna-singleton-resolver
Copy link
Collaborator

@anna-singleton-resolver anna-singleton-resolver commented Mar 5, 2026

We should allow users of the client library to select which e2e test cases are runnable. This would allow us to easily run the benign cases as well as the live ones, to make the e2e cases useful against development environments which do not have access to the live versions of the classifiers

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds environment-driven selection of end-to-end (E2E) test case sets so the E2E classifier test can be run against different testcase directories without code changes.

Changes:

  • Introduce load_test_cases_by_env() to select the testcase directory via ATHENA_E2E_TESTCASE_DIR (defaulting to integrator_sample).
  • Update test_classify_single to use the new env-based loader instead of a hard-coded testcase directory.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/functional/e2e/testcases/parser.py Adds an env-based testcase loader wrapper around load_test_cases().
tests/functional/e2e/test_classify_single.py Switches testcase initialization to use the env-based loader.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@anna-singleton-resolver
Copy link
Collaborator Author

superseded by #117 , PR is no longer necessary

auto-merge was automatically disabled March 9, 2026 10:00

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants