feat: configurable e2e test cases#116
Closed
anna-singleton-resolver wants to merge 3 commits intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds environment-driven selection of end-to-end (E2E) test case sets so the E2E classifier test can be run against different testcase directories without code changes.
Changes:
- Introduce
load_test_cases_by_env()to select the testcase directory viaATHENA_E2E_TESTCASE_DIR(defaulting tointegrator_sample). - Update
test_classify_singleto use the new env-based loader instead of a hard-coded testcase directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/functional/e2e/testcases/parser.py |
Adds an env-based testcase loader wrapper around load_test_cases(). |
tests/functional/e2e/test_classify_single.py |
Switches testcase initialization to use the env-based loader. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
snus-kin
approved these changes
Mar 6, 2026
Merged
Collaborator
Author
|
superseded by #117 , PR is no longer necessary |
auto-merge was automatically disabled
March 9, 2026 10:00
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should allow users of the client library to select which e2e test cases are runnable. This would allow us to easily run the benign cases as well as the live ones, to make the e2e cases useful against development environments which do not have access to the live versions of the classifiers