Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the application data to align with DLC timeline content, primarily focusing on internationalization improvements and game data updates for the X4 game.
Key Changes:
- Migrated from XLIFF (.xlf) translation format to JSON format for both English and Chinese translations
- Added Boron faction to illegal wares (spaceweed and spacefuel)
- Added new ship types (expeditionary, envoy), ship purpose (racing), and module type (radar)
- Enhanced i18n support across multiple HTML components with translation markup
Reviewed changes
Copilot reviewed 43 out of 132 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/i18n/messages.*.xlf | Deleted legacy XLIFF translation files |
| src/i18n/messages.json | New JSON-based English translations |
| src/i18n/messages.zh-Hans.json | New JSON-based Chinese translations |
| src/app/ware/components/ware-detail.component.html | Reformatted code with consistent indentation |
| src/app/station/components/*.html | Added i18n translation markers to UI labels |
| src/app/ship/components/ships.component.html | Fixed incorrect i18n tag from stationModules to ships |
| src/app/header.component.html | Added i18n markers to navigation links |
| src/app/shared/services/data/wares-data.ts | Added Boron faction to illegal items, reformatted indentation |
| src/app/shared/services/data/*-data.ts | Added new enum values for DLC content, reformatted code |
| package.json | Added new build/watch scripts for Chinese localization |
| docs/runtime-*.js | Deleted old runtime files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "production": " Production", | ||
| "profit": " Profit", | ||
| "minersProvideBasicResources": "Miners provide basic resources", | ||
| "rovideAllResources": "Resources are provided by other stations", |
There was a problem hiding this comment.
Typo in translation key. The key "rovideAllResources" is missing the leading "p" and should be "provideAllResources" to match the pattern of other keys.
| "production": "产品", | ||
| "profit": "利润", | ||
| "minersProvideBasicResources": "由矿工提供基本资源", | ||
| "rovideAllResources": "资源由其他空间站提供", |
There was a problem hiding this comment.
Typo in translation key. The key "rovideAllResources" is missing the leading "p" and should be "provideAllResources" to match the pattern of other keys.
| icon: 'race_xenon', | ||
| id: 'xenon', | ||
| name: 'Xenon', | ||
| description: 'The Xenon are a mechanical race resulting from past Terran Terraformer ships which eventually evolved intelligence. A constant threat in many areas of the galaxy, it is thought that the Jump Gate shutdown may stem their movements but given their disregard of time it is possible they may simply travel between stars. The Xenon have no known allies and communication with them is often relegated to folklore.', |
There was a problem hiding this comment.
Typo in word "Terraformer". The description text contains "past Terran Terraformer ships" but should be "past Terran terraformer ships" for consistency with the description in the Terran race entry which uses "Terraformers" (lowercase when not starting a sentence).
No description provided.