Skip to content

[WIP] Ship details#29

Open
Rayman2200 wants to merge 8 commits intocrissian:devfrom
Rayman2200:ship-details
Open

[WIP] Ship details#29
Rayman2200 wants to merge 8 commits intocrissian:devfrom
Rayman2200:ship-details

Conversation

@Rayman2200
Copy link
Copy Markdown

I've started to expand the table with additional ship data.

Speed, Acceleration and Cargo are the new columns. For travel speed I would need additional data from within the game data.

Additionally I've added a persistance to the data table. So if someone set some filter, they will be stored in the LocalStorage. Also a "Column Chooser" is available to filter out the visible columns.

image

The speed and acceleration is taken from the best available engine. I've added a footer with the info.

I've only picked some ships for testing and compared them with the ingme encyclopedia.

If you could provide the additional data, I will expand the table.

@crissian
Copy link
Copy Markdown
Owner

crissian commented Jun 5, 2020

Sorry for the delay, I just added the travel data. My time is limited so please go ahead and make the needed changes in your PR, then I'll merge and deploy.

Thanks.

@Rayman2200
Copy link
Copy Markdown
Author

No problem, my time is also limited.

I want to finish the ship detail page as well. The goal is to have a select box with all compatible engines.

Maybe the main weapons, turrets and shields will be also included in this PR. Depending how complicated it will be to serve a dynamic amount of select boxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants