Allow to pass port to clone:allow command#18
Open
weyert wants to merge 2 commits intocrisward:masterfrom
Open
Conversation
Allow passing a port as second argument so domains were SSH is running on a different port then 22 are supported too
decentral1se
suggested changes
Mar 15, 2020
Contributor
decentral1se
left a comment
There was a problem hiding this comment.
You should also document this argument on the usage output?
Looks good though, wondering why this hasn't been reviewed / commented on 😕
Owner
Usual reason, not something I need so didn't get round to testing / merging. To manually test this kind of thing feels like it'd take an age
I mean I could just blindly merge it but that's bound to break the code in a difficult to predict way. I'm not a bash guru or anything so may have missed something. Another solution to use a different port is to add something to your ~/.ssh/config file eg Though I can see why it'd be easier to do this on the cli each time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are running SSH on a different port then 22 this command would fail. I have added the optional argument to pass the port it will fallback to 22 when not given