feat: support group-level site rules in shortcut packs#833
Open
crittermike wants to merge 1 commit intomasterfrom
Open
feat: support group-level site rules in shortcut packs#833crittermike wants to merge 1 commit intomasterfrom
crittermike wants to merge 1 commit intomasterfrom
Conversation
Add optional groupSettings field to ShortcutPack interface so packs can specify activateOn/deactivateOn site rules for the entire group. When a pack includes groupSettings, installPack writes them alongside the shortcuts. Also moves useGroups reactive state to module scope (same singleton pattern as useShortcuts, useToast, useJsTools) so groupSettings is shared across all consumers. Includes 4 tests covering: basic install, both filter fields, no-groupSettings packs, and preserving existing group settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for group-level
activateOn/deactivateOnsite rules in shortcut packs, so app-specific packs (like OnePageCRM) can restrict all their shortcuts to the relevant domain.Changes
ShortcutPackinterface — new optionalgroupSettingsfield withactivateOn/deactivateOninstallPack— writes group settings to storage when present in the packuseGroups— moved reactive state to module scope (singleton pattern, same asuseShortcuts/useToast/useJsTools) sogroupSettingsis shared betweenApp.vueandusePacksExample pack JSON
{ "name": "OnePageCRM", "description": "CRM shortcuts", "groupSettings": { "activateOn": "https://app.onepagecrm.com/*" }, "shortcuts": [...] }Tests
4 new tests (746 total):
Related to #811