Pin rdoc below 8 to fix JRuby CI#831
Merged
Merged
Conversation
rdoc 8.0.0 added a runtime dependency on rbs >= 4.0.0, whose C extension fails to compile on JRuby (rbs publishes no java platform gem for 4.0.x). Every fresh bundle install on the JRuby matrix cell has failed since rdoc 8.0.0 was released on 2026-06-26. Pin rdoc to < 8 and regenerate the appraisal gemfiles. The pin can be dropped once rbs ships a java platform release (4.1.0.pre.2 already includes one) or rdoc relaxes the dependency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 169 169
Lines 7713 7713
Branches 1284 1284
=======================================
Hits 6317 6317
Misses 884 884
Partials 512 512 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
crmne
requested changes
Jul 3, 2026
| gem 'pry', '>= 0.14' | ||
| gem 'rails' | ||
| gem 'rake', '>= 13.0' | ||
| gem 'rdoc', '< 8' |
Owner
There was a problem hiding this comment.
gem 'rdoc', '< 8', platform: 'jruby'
Then regen the appraisal gemfiles
crmne
approved these changes
Jul 3, 2026
crmne
left a comment
Owner
There was a problem hiding this comment.
Looks good. I pushed the small follow-up to make the rdoc pin JRuby-only and regenerate the appraisal gemfiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
rdoc 8.0.0 (released 2026-06-26) added a runtime dependency on
rbs >= 4.0.0. On JRuby, Bundler resolvesrails → railties → irb → rdoc 8.0.0 → rbs 4.0.3, and rbs 4.0.3 ships only aruby-platform gem whose C extension (ext/rbs_extension) fails to compile under JRuby 10 (append_cflagsfails in extconf.rb).Since no lockfiles are committed, every CI job resolves gems fresh — so the
Test (jruby-10.0.2.0 / rails-7.1)matrix cell has failed duringbundle installon every PR run since 2026-06-26 (e.g. #830's run), before tests even start, and its failure fail-fast-cancels the rest of the matrix.main's last run (2026-06-23) predates the rdoc release, which is why it's still green.This pins
rdoc < 8in the Gemfile's development group and regenerates the appraisal gemfiles withbundle exec appraisal generateso the pin propagates to all matrix cells. rdoc 7.2.0 has no rbs dependency, so JRuby no longer attempts the native build.The pin can be dropped once rbs ships a final release with a
java-platform gem (4.1.0.pre.2 already includes one) or rdoc relaxes the hard rbs dependency.Type of change
Scope check
Required for new features
N/A — CI dependency fix.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name](N/A — Gemfile-only change, no provider/HTTP code touched)bundle installresolves rdoc to 7.2.0 (no rbs in the tree) andrequire 'ruby_llm'loads cleanly; no library or spec code changedmodels.json,aliases.json) (appraisal gemfiles regenerated viabundle exec appraisal generate)API changes